fix: Propagate Stream Errors through the same Future #1732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wait simultaneously for async calls (Futures and Streams) to ensure all errors are propagated through one common future. Previously a stream could throw an error before it was even listened to, as the process still awaited an async call (here
setSource
).Checklist
fix:
,feat:
,refactor:
,docs:
,chore:
,test:
,ci:
etc).///
, where necessary.The tests are adapted, but not explicitly written to avoid that error. But the error would occur since Flutter 3.16.x, so they are tested against in #1715 without further ado.
Breaking Change
Related Issues
#1715