Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free mypy #1649

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Free mypy #1649

merged 1 commit into from
Dec 15, 2021

Conversation

infirit
Copy link
Contributor

@infirit infirit commented Dec 14, 2021

Tested with version 0.910

mypy has been nice to me and the blueman code so let's free it for now.
@infirit
Copy link
Contributor Author

infirit commented Dec 14, 2021

This takes care of mypy failing on python 3.11

@cschramm
Copy link
Member

I'm eagerly monitoring python/mypy#11158 as I would have bumped to 0.920 once it's available, but freeing it is fine for me as well. I'm actually surprised that 0.910 works with Python 3.11 as I expected python/mypy#11531 / python/mypy#11560 to be required (to get typed_ast 1.5.1 with python/typed_ast#176) but that's not part of a release yet. 🤔

@infirit infirit merged commit 72bebc6 into blueman-project:main Dec 15, 2021
@infirit infirit deleted the mypy branch December 15, 2021 10:56
@infirit
Copy link
Contributor Author

infirit commented Dec 15, 2021

If it starts causing issues again I'll pin it again to a version. Happy to see those failed checks gone 😁

@hauntsaninja
Copy link

hauntsaninja commented Dec 16, 2021

Recent versions of mypy only require typed-ast if you're running with Python 3.7 or lower, or if you want to check Python 2 code :-)

@cschramm
Copy link
Member

Right. python/mypy@4adb5e4 is the crucial change. The compilation error actually only affects 0.812 while 0.900 and newer just do not even try to install typed-ast on Python 3.11. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants