Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting additional properties of streams through description.Session #368

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Aug 17, 2023

No description provided.

@aler9 aler9 force-pushed the dev/sd branch 2 times, most recently from 0273255 to a37ff20 Compare August 18, 2023 16:26
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #368 (4a482cf) into v4 (4e000eb) will decrease coverage by 0.02%.
The diff coverage is 86.29%.

@@            Coverage Diff             @@
##               v4     #368      +/-   ##
==========================================
- Coverage   84.76%   84.75%   -0.02%     
==========================================
  Files         101      101              
  Lines       10189    10193       +4     
==========================================
+ Hits         8637     8639       +2     
- Misses       1193     1194       +1     
- Partials      359      360       +1     
Files Changed Coverage Δ
client.go 74.12% <72.09%> (+0.04%) ⬆️
pkg/description/media.go 91.44% <83.33%> (ø)
server_session.go 79.20% <90.90%> (ø)
pkg/description/session.go 91.83% <94.73%> (ø)
client_media.go 92.85% <100.00%> (ø)
server_conn.go 90.85% <100.00%> (+0.05%) ⬆️
server_session_media.go 94.71% <100.00%> (ø)
server_stream.go 85.56% <100.00%> (ø)
server_stream_media.go 90.62% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 force-pushed the dev/sd branch 2 times, most recently from c6fb498 to 9426674 Compare August 18, 2023 16:31
@aler9 aler9 changed the title allow setting additional properties of streams through description.Stream allow setting additional properties of streams through description.Session Aug 18, 2023
@aler9 aler9 merged commit cdbecb1 into v4 Aug 22, 2023
8 of 9 checks passed
@aler9 aler9 deleted the dev/sd branch August 22, 2023 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant