Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix compatibility with rtspclientsink and query parameters (bluenviron/mediamtx#3295) #619

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Sep 15, 2024

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.86%. Comparing base (2023bf1) to head (08b0e45).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server_session.go 87.50% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   81.88%   81.86%   -0.02%     
==========================================
  Files         115      115              
  Lines       11625    11637      +12     
==========================================
+ Hits         9519     9527       +8     
- Misses       1703     1706       +3     
- Partials      403      404       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit c682ff5 into main Sep 15, 2024
8 of 9 checks passed
@aler9 aler9 deleted the fix/rtspclientsink branch September 15, 2024 20:18
@neilyoung
Copy link

Hey, cool. So it is fixed in 1.9.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTSP/1.0 400 Bad Request when query parameters are supplied in RTSP URL
2 participants