Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h264: Fix DTS Extractor when single SEI NALU is received #142

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

gkubes
Copy link
Contributor

@gkubes gkubes commented Aug 14, 2024

bluenviron/mediamtx#3614

On a TP-Link Tapo C120 camera, an AU is received with a single SEI NALU. This causes issues within the DTS_Extractor because neither an IDR or non-IDR NALU is received.

This change returns the previously calculated DTS value in the case that only NALUs that are not necessary to reconstruct the reference pictures are received as defined by the nal_ref_idc bits indicate.

@gkubes
Copy link
Contributor Author

gkubes commented Aug 22, 2024

@aler9 looks like you updated the github actions config just after I posed this pull request. Do I need to resubmit this request to get the 2 workflows to run?

@aler9
Copy link
Member

aler9 commented Aug 25, 2024

Hello, i'm not particularly convinced about the nal_ref_id - based algorithm, but, since this does not conflict with any existing unit test, and since you provided an additional unit test that may allow to change the algorithm in the future without breaking compatibility with the TP-Link camera, i think this can be merged. Thanks!

@aler9 aler9 merged commit b1ff744 into bluenviron:main Aug 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants