Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HLS client #1179

Merged
merged 19 commits into from
Oct 23, 2022
Merged

Improve HLS client #1179

merged 19 commits into from
Oct 23, 2022

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Oct 9, 2022

Fixes #1094

TODO:

  • support fmp4 streams with video only
  • start reading live streams from (end of playlist - starting point)
  • support audio in separate playlist
  • support fmp4 streams with video + audio
  • support EXT-X-BYTERANGE
  • synchronize stream reproduction around a leading track
  • reset stream in case playback is too late
  • add tests for everything

@aler9 aler9 mentioned this pull request Oct 9, 2022
13 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #1179 (68b6443) into main (847ca6c) will decrease coverage by 0.95%.
The diff coverage is 55.82%.

@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
- Coverage   69.80%   68.84%   -0.96%     
==========================================
  Files         102      106       +4     
  Lines        8485     8847     +362     
==========================================
+ Hits         5923     6091     +168     
- Misses       2012     2194     +182     
- Partials      550      562      +12     
Impacted Files Coverage Δ
internal/hls/client_processor_fmp4.go 0.00% <0.00%> (ø)
internal/hls/client_processor_fmp4_track.go 0.00% <0.00%> (ø)
internal/hls/mpegts/tracks.go 0.00% <0.00%> (ø)
internal/hls/mpegts/writer.go 90.38% <ø> (ø)
internal/hls/client_timesync_fmp4.go 34.48% <34.48%> (ø)
internal/hls/client_downloader_primary.go 40.86% <40.86%> (ø)
internal/hls/client_downloader_stream.go 47.48% <47.48%> (ø)
internal/hls/client_timesync_mpegts.go 60.00% <60.00%> (ø)
internal/hls/fmp4/init.go 63.33% <63.33%> (ø)
internal/hls/fmp4/part.go 67.37% <67.37%> (ø)
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit e5ab731 into main Oct 23, 2022
@aler9 aler9 deleted the hls-client branch October 23, 2022 12:04
@aler9
Copy link
Member Author

aler9 commented Oct 25, 2022

added in v0.20.1

@github-actions
Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LL-HLS inputs not working
2 participants