Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print warning in case no key frames are being received #1763

Merged
merged 2 commits into from
May 4, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented May 4, 2023

No description provided.

@aler9 aler9 changed the title Feature keyframe warn print warning in case no key frames are being received May 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1763 (74a0a10) into main (22fe655) will increase coverage by 0.12%.
The diff coverage is 58.79%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1763      +/-   ##
==========================================
+ Coverage   62.98%   63.11%   +0.12%     
==========================================
  Files          91       91              
  Lines       10072    10087      +15     
==========================================
+ Hits         6344     6366      +22     
+ Misses       3276     3270       -6     
+ Partials      452      451       -1     
Impacted Files Coverage Δ
internal/conf/logdestination.go 0.00% <0.00%> (ø)
internal/core/pprof.go 0.00% <0.00%> (ø)
internal/core/rpicamera_source.go 0.00% <0.00%> (ø)
internal/core/source.go 100.00% <ø> (ø)
internal/core/source_redirect.go 0.00% <0.00%> (ø)
internal/core/udp_source.go 0.00% <0.00%> (ø)
internal/formatprocessor/generic.go 56.00% <ø> (ø)
internal/formatprocessor/mpeg2audio.go 0.00% <0.00%> (ø)
internal/formatprocessor/mpeg4audio.go 0.00% <0.00%> (ø)
internal/formatprocessor/opus.go 0.00% <0.00%> (ø)
... and 27 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 225220d into main May 4, 2023
@aler9 aler9 deleted the feature-keyframe-warn branch May 4, 2023 18:16
@alpe12
Copy link

alpe12 commented May 17, 2023

@aler9

My WEBRTC streams always freezes every few minutes.
With the latest update I'm getting these errors.
WAR [path cam] no H264 key frames received in %!v(MISSING), stream can't be decoded
My camera records with large keyframes interval when there is little motion, to save disk space.
Could this be causing issues with WEBRTC in meadiamtx? Via RTSP on mediamtx it mostly works. It freezes only (or way more) on WEBRTC.
What to do to fix WEBRTC then?
If this doesn't explain WEBRTC freezing (and not RTSP) can you add an option to disable these warning or to configure the allowed keyframe interval?

I really don't understand why only WEBRTC freezes.
Thanks.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants