Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRT Metrics #2962

Merged
merged 11 commits into from
Feb 16, 2024
Merged

SRT Metrics #2962

merged 11 commits into from
Feb 16, 2024

Conversation

nerdbaggy
Copy link
Contributor

This is the start of the SRT metrics. It should all be in there minus the prometheus endpoint, that is still a WIP.

The variable names and comments were pulled from https://github.com/datarhei/gosrt/blob/main/statistics.go since he has better than I could think of.

I do not have any of the StatisticsInterval metrics because that can all be derived from prometheus queries.

@nerdbaggy nerdbaggy marked this pull request as ready for review January 29, 2024 19:13
@nerdbaggy nerdbaggy changed the title DRAFT: SRT Metrics SRT Metrics Jan 29, 2024
@nerdbaggy
Copy link
Contributor Author

All tests should pass now with the exception to the lint test.

The lint test says that the line length are too long. This is due to the comments about what each metric is for. Do you want me to remove the comment or should it just be ignored for that struct?
https://github.com/nerdbaggy/mediamtx/blob/srt-metrics/internal/defs/api.go#L165

@nerdbaggy
Copy link
Contributor Author

Should be good to go for real this time. The tests has been fixed and the lint issue has been fixed

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (e46a124) 53.58% compared to head (2f1f4bc) 53.37%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/servers/srt/conn.go 0.00% 60 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2962      +/-   ##
==========================================
- Coverage   53.58%   53.37%   -0.21%     
==========================================
  Files         137      137              
  Lines       13697    13747      +50     
==========================================
- Hits         7340     7338       -2     
- Misses       5766     5818      +52     
  Partials      591      591              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nerdbaggy
Copy link
Contributor Author

Is there anything else you would like me to do
in this PR? While Codecov says that it isn’t covered, the metrics code does get tested when the Prometheus endpoint is tested.

@aler9 aler9 merged commit e5e029a into bluenviron:main Feb 16, 2024
6 of 8 checks passed
@aler9
Copy link
Member

aler9 commented Feb 16, 2024

merged, thanks!

Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue is mentioned in release v1.6.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants