-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRT Metrics #2962
SRT Metrics #2962
Conversation
All tests should pass now with the exception to the lint test. The lint test says that the line length are too long. This is due to the comments about what each metric is for. Do you want me to remove the comment or should it just be ignored for that struct? |
Should be good to go for real this time. The tests has been fixed and the lint issue has been fixed |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2962 +/- ##
==========================================
- Coverage 53.58% 53.37% -0.21%
==========================================
Files 137 137
Lines 13697 13747 +50
==========================================
- Hits 7340 7338 -2
- Misses 5766 5818 +52
Partials 591 591 ☔ View full report in Codecov by Sentry. |
Is there anything else you would like me to do |
merged, thanks! |
This issue is mentioned in release v1.6.0 🚀 |
This is the start of the SRT metrics. It should all be in there minus the prometheus endpoint, that is still a WIP.
The variable names and comments were pulled from https://github.com/datarhei/gosrt/blob/main/statistics.go since he has better than I could think of.
I do not have any of the
StatisticsInterval
metrics because that can all be derived from prometheus queries.