Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp: add new AMF0 encoder and encoder #3069

Merged
merged 1 commit into from
Feb 24, 2024
Merged

rtmp: add new AMF0 encoder and encoder #3069

merged 1 commit into from
Feb 24, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Feb 24, 2024

This improves performance, security and removes a dependency.

This improves performance, security and removes a dependency.
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 88.17481% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 55.48%. Comparing base (e06155b) to head (92b3093).

Files Patch % Lines
internal/protocols/rtmp/amf0/marshal.go 89.14% 10 Missing and 4 partials ⚠️
internal/protocols/rtmp/amf0/object.go 50.00% 9 Missing and 4 partials ⚠️
internal/protocols/rtmp/amf0/unmarshal.go 97.52% 2 Missing and 1 partial ⚠️
internal/protocols/rtmp/message/command_amf0.go 76.92% 2 Missing and 1 partial ⚠️
internal/protocols/rtmp/message/data_amf0.go 62.50% 2 Missing and 1 partial ⚠️
...ternal/protocols/rtmp/message/extended_metadata.go 0.00% 2 Missing ⚠️
...ls/rtmp/message/extended_mpeg2ts_sequence_start.go 0.00% 2 Missing ⚠️
...al/protocols/rtmp/message/extended_sequence_end.go 0.00% 2 Missing ⚠️
...ernal/protocols/rtmp/message/set_peer_bandwidth.go 0.00% 2 Missing ⚠️
...rnal/protocols/rtmp/message/set_window_ack_size.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3069      +/-   ##
==========================================
+ Coverage   54.90%   55.48%   +0.57%     
==========================================
  Files         146      149       +3     
  Lines       16071    16357     +286     
==========================================
+ Hits         8824     9075     +251     
- Misses       6540     6564      +24     
- Partials      707      718      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit da7c574 into main Feb 24, 2024
8 checks passed
@aler9 aler9 deleted the feature/amf0 branch February 24, 2024 18:11
Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue is mentioned in release v1.6.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant