-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend AMF0 decode implementation #3189
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3189 +/- ##
==========================================
- Coverage 55.95% 55.53% -0.42%
==========================================
Files 154 151 -3
Lines 16993 16909 -84
==========================================
- Hits 9508 9391 -117
- Misses 6734 6779 +45
+ Partials 751 739 -12 ☔ View full report in Codecov by Sentry. |
Fixed comment error and tests added |
Hello, thank you very much for this patch - just one question, i noticed that you edited the parser in order to silently skip markerUnsupported and markerUndefined. Silently skipping things is something we've always avoided unless strictly necessary, because it makes detecting problems harder. Are you sure that this is necessary? thanks |
Hello, It is not necessary, I only did this to avoid close a connection if this types are received because the connection could be possible skipping it. Maybe a good solution could be show a warning log for debug purpose. |
…L documents, date
bd62144
to
3cbdcff
Compare
i implemented StrictArray marshaling, added fuzz tests and removed the long string / XML / date handling, since those last entities are seldom used and would require additional logic. If you encounter these entities in the future, feel free to submit another patch. |
This issue is mentioned in release v1.7.0 🚀 |
Hello,
I did this PR to fix the error mentioned here:
#3188
Also, I added others AMF0 types to decode extending the support:
With this, the server should support all AMF0 types decode except recordedset, movieclip and typed-object.
recordedset and movieclip are reserved so you can ignore it.
typed-object is a custom object serialized so ignored it should be fine too
Note: Strict Array implementation return nil value because I'm not sure how to return an array of item. Maybe you need fix it or give me a tip for it ( I'm new with golang :( )