Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playback: do not concatenate segments with different tracks #3197

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Apr 6, 2024

No description provided.

@aler9 aler9 force-pushed the fix/playback-tracks branch 2 times, most recently from 41d71fa to 4f1cfe3 Compare April 6, 2024 17:57
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 48.35165% with 188 lines in your changes are missing coverage. Please review.

Project coverage is 55.72%. Comparing base (87c0535) to head (a327144).

Files Patch % Lines
internal/playback/fmp4.go 48.48% 56 Missing and 29 partials ⚠️
internal/playback/on_get.go 45.37% 51 Missing and 14 partials ⚠️
internal/playback/on_list.go 51.28% 28 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3197      +/-   ##
==========================================
+ Coverage   55.69%   55.72%   +0.03%     
==========================================
  Files         151      153       +2     
  Lines       16875    16898      +23     
==========================================
+ Hits         9398     9416      +18     
- Misses       6738     6740       +2     
- Partials      739      742       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 50322fc into main Apr 6, 2024
7 of 8 checks passed
@aler9 aler9 deleted the fix/playback-tracks branch April 6, 2024 18:01
Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant