Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playaback: use a fixed fMP4 part duration #3203

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Apr 7, 2024

No description provided.

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 55.76%. Comparing base (0a8e626) to head (58c91fc).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/playback/muxer_fmp4.go 72.22% 8 Missing and 2 partials ⚠️
internal/playback/segment_fmp4.go 25.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
+ Coverage   55.74%   55.76%   +0.01%     
==========================================
  Files         154      154              
  Lines       16917    16941      +24     
==========================================
+ Hits         9431     9447      +16     
- Misses       6741     6748       +7     
- Partials      745      746       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the fix/playback-part-duration branch 2 times, most recently from eb356c1 to afbbec5 Compare April 7, 2024 20:26
@aler9 aler9 force-pushed the fix/playback-part-duration branch from afbbec5 to 58c91fc Compare April 7, 2024 20:29
@aler9 aler9 merged commit d5a18bf into main Apr 7, 2024
8 checks passed
@aler9 aler9 deleted the fix/playback-part-duration branch April 7, 2024 20:33
Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant