Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playback: fix bug that messed up duration of last sample of each track #3210

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Apr 8, 2024

No description provided.

@aler9 aler9 changed the title Fix/playback last dts playback: fix bug that messed up duration of last sample of each track Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 55.76%. Comparing base (34b120f) to head (c3860a7).
Report is 1 commits behind head on main.

❗ Current head c3860a7 differs from pull request most recent head 2e08684. Consider uploading reports for the commit 2e08684 to get more accurate results

Files Patch % Lines
internal/playback/segment_fmp4.go 81.81% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3210      +/-   ##
==========================================
+ Coverage   55.74%   55.76%   +0.02%     
==========================================
  Files         154      154              
  Lines       16941    16959      +18     
==========================================
+ Hits         9444     9458      +14     
- Misses       6751     6754       +3     
- Partials      746      747       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 14bf7f4 into main Apr 8, 2024
6 checks passed
@aler9 aler9 deleted the fix/playback-last-dts branch April 8, 2024 21:01
Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant