Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support HTTPS, Allow-Origin and trusted proxies in API, playback server, metrics server and pprof server (#2658) (#2491) (#3235) #3280

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Apr 21, 2024

Fixes #2491
Fixes #3235
Replaces #2658

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 74.04255% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 52.62%. Comparing base (9e63630) to head (87b7956).

Files Patch % Lines
internal/pprof/pprof.go 0.00% 25 Missing ⚠️
internal/metrics/metrics.go 0.00% 20 Missing ⚠️
internal/protocols/httpp/wrapped_server.go 55.00% 7 Missing and 2 partials ⚠️
internal/playback/server.go 82.92% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3280      +/-   ##
==========================================
+ Coverage   52.50%   52.62%   +0.11%     
==========================================
  Files         191      191              
  Lines       19930    19988      +58     
==========================================
+ Hits        10465    10518      +53     
- Misses       8607     8614       +7     
+ Partials      858      856       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the feature/https-allow-origin branch from 0058746 to 87b7956 Compare April 21, 2024 15:04
@aler9 aler9 merged commit 85dd816 into main Apr 21, 2024
8 checks passed
@aler9 aler9 deleted the feature/https-allow-origin branch April 21, 2024 15:10
Copy link
Contributor

This issue is mentioned in release v1.8.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support HTTPS in playback server HTTPS for API endpoints
1 participant