Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: support reading and proxying multichannel Opus (#3371) #3375

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented May 19, 2024

Fixes #3371

TODO

  • [ ] fix "frame is too big error" (inside RTP Opus encoder)
  • test reading multichannel Opus with Chrome
  • test reading multichannel Opus with Firefox
  • test reading multichannel Opus with iOs Safari
  • error message in Firefox and in all browsers that do not support this
  • test proxying multichannel Opus between two MediaMTX instances

@aler9 aler9 force-pushed the feature/webrtc-multiopus branch from c443f75 to 310ba0c Compare May 19, 2024 18:01
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.56%. Comparing base (c37e895) to head (8f10f1c).

Files Patch % Lines
internal/protocols/webrtc/incoming_track.go 83.33% 1 Missing ⚠️
internal/protocols/webrtc/peer_connection.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3375      +/-   ##
==========================================
+ Coverage   53.97%   55.56%   +1.59%     
==========================================
  Files         190      190              
  Lines       18879    18893      +14     
==========================================
+ Hits        10190    10498     +308     
+ Misses       7890     7586     -304     
- Partials      799      809      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the feature/webrtc-multiopus branch 2 times, most recently from bba46f0 to 989b91b Compare May 26, 2024 20:46
@aler9 aler9 changed the title webrtc: support reading and publishing multichannel Opus (#3371) webrtc: support reading and proxying multichannel Opus (#3371) May 27, 2024
@aler9 aler9 force-pushed the feature/webrtc-multiopus branch 6 times, most recently from bbf3d0c to d311d2c Compare June 2, 2024 22:19
@aler9 aler9 force-pushed the feature/webrtc-multiopus branch from d311d2c to 8f10f1c Compare June 2, 2024 22:20
@aler9 aler9 merged commit ca16389 into main Jun 2, 2024
8 checks passed
@aler9 aler9 deleted the feature/webrtc-multiopus branch June 2, 2024 22:26
Copy link
Contributor

This issue is mentioned in release v1.8.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow reading Multichannel Opus streams with WebRTC
1 participant