Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: support reading and proxying stereo PCMU/PCMA tracks #3402

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented May 27, 2024

TODO:

  • error message in Firefox and in all browsers that do not support this

@aler9 aler9 force-pushed the feature/pcma-samplerate-channels branch from 8f5a0e8 to 73b0e13 Compare May 29, 2024 19:57
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 54.00%. Comparing base (6da8aee) to head (6d542dd).

Files Patch % Lines
internal/protocols/webrtc/outgoing_track.go 0.00% 30 Missing ⚠️
internal/protocols/webrtc/incoming_track.go 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3402      +/-   ##
==========================================
- Coverage   54.06%   54.00%   -0.07%     
==========================================
  Files         190      190              
  Lines       18847    18879      +32     
==========================================
+ Hits        10190    10195       +5     
- Misses       7858     7885      +27     
  Partials      799      799              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the feature/pcma-samplerate-channels branch from 73b0e13 to dede7b5 Compare June 2, 2024 21:05
@aler9 aler9 force-pushed the feature/pcma-samplerate-channels branch from dede7b5 to 6d542dd Compare June 2, 2024 21:06
@aler9 aler9 merged commit ca6e125 into main Jun 2, 2024
6 of 8 checks passed
@aler9 aler9 deleted the feature/pcma-samplerate-channels branch June 2, 2024 21:08
Copy link
Contributor

This issue is mentioned in release v1.8.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant