Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: support passing username and password through Bearer Token (#3248) #3459

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 11, 2024

No description provided.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 57.77778% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@caa9fa6). Learn more about missing BASE report.

Current head 521c94a differs from pull request most recent head 9a04092

Please upload reports for the commit 9a04092 to get more accurate results.

Files Patch % Lines
internal/servers/webrtc/http_server.go 56.25% 12 Missing and 2 partials ⚠️
internal/servers/hls/http_server.go 61.53% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3459   +/-   ##
=======================================
  Coverage        ?   56.44%           
=======================================
  Files           ?      190           
  Lines           ?    19160           
  Branches        ?        0           
=======================================
  Hits            ?    10815           
  Misses          ?     7522           
  Partials        ?      823           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 39ae126 into main Jun 11, 2024
6 checks passed
@aler9 aler9 deleted the feature/webrtc-bearer branch June 11, 2024 21:38
Copy link
Contributor

This issue is mentioned in release v1.8.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant