Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record, hls: fix panic with MPEG-4 audio tracks without config (#3590) #3594

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Aug 1, 2024

No description provided.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 62.67606% with 53 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@da5420a). Learn more about missing BASE report.

Files Patch % Lines
internal/servers/hls/muxer_instance.go 0.00% 21 Missing ⚠️
internal/record/format_fmp4.go 60.97% 12 Missing and 4 partials ⚠️
internal/record/format_mpegts.go 65.62% 8 Missing and 3 partials ⚠️
internal/protocols/mpegts/from_stream.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3594   +/-   ##
=======================================
  Coverage        ?   57.07%           
=======================================
  Files           ?      190           
  Lines           ?    19176           
  Branches        ?        0           
=======================================
  Hits            ?    10944           
  Misses          ?     7402           
  Partials        ?      830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 0230aa0 into main Aug 1, 2024
8 checks passed
@aler9 aler9 deleted the fix/mpeg4 branch August 1, 2024 14:34
Copy link
Contributor

github-actions bot commented Aug 4, 2024

This issue is mentioned in release v1.8.5 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant