Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hls: fix playback speed on iOS (#3155) (#3731) #3734

Merged
merged 1 commit into from
Sep 8, 2024
Merged

hls: fix playback speed on iOS (#3155) (#3731) #3734

merged 1 commit into from
Sep 8, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Sep 4, 2024

Fixes #3155
Replaces #3731

@deepseth
Copy link

deepseth commented Sep 4, 2024

To note that the device I was testing on iOS with was an iPhone 13 mini running iOS 17.6.1, not an iPad.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.12%. Comparing base (3b7b230) to head (2f5d29f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3734      +/-   ##
==========================================
+ Coverage   57.09%   57.12%   +0.03%     
==========================================
  Files         191      191              
  Lines       19318    19318              
==========================================
+ Hits        11029    11036       +7     
+ Misses       7446     7442       -4     
+ Partials      843      840       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 changed the title hls: fix playback speed in iPad iOS (#3155) (#3731) hls: fix playback speed on iOS (#3155) (#3731) Sep 4, 2024
@aler9
Copy link
Member Author

aler9 commented Sep 4, 2024

@deepseth thanks for the feedback, i looked around and it seems like iPhone started supporting Media Source Extensions (and therefore hls.js) since iOS 17, but maxLiveSyncPlaybackRate is still causing troubles, therefore it's better to use the native HLS implementation.

@deepseth
Copy link

deepseth commented Sep 4, 2024

Super, thank you for looking at this so quickly!

@aler9 aler9 merged commit 1f47832 into main Sep 8, 2024
8 checks passed
@aler9 aler9 deleted the fix/hls branch September 8, 2024 18:29
Copy link
Contributor

This issue is mentioned in release v1.9.1 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HLS streaming playback speed is 1.5x for mobile devices with no option to change
2 participants