Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cleaning of recordings in case of multiple recordDeleteAfter values (#3557) #3741

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Sep 5, 2024

Fixes #3557

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 77.88462% with 69 lines in your changes missing coverage. Please review.

Project coverage is 57.09%. Comparing base (6e9d79c) to head (a84a4a8).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/recordstore/segment.go 76.54% 26 Missing and 12 partials ⚠️
internal/recordcleaner/cleaner.go 70.83% 17 Missing and 4 partials ⚠️
internal/conf/path.go 0.00% 6 Missing ⚠️
internal/playback/on_get.go 33.33% 2 Missing ⚠️
internal/playback/on_list.go 66.66% 1 Missing ⚠️
internal/playback/segment_fmp4.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3741      +/-   ##
==========================================
+ Coverage   57.08%   57.09%   +0.01%     
==========================================
  Files         191      190       -1     
  Lines       19318    19297      -21     
==========================================
- Hits        11027    11017      -10     
+ Misses       7448     7434      -14     
- Partials      843      846       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 73a300a into main Sep 8, 2024
8 checks passed
@aler9 aler9 deleted the fix/recordclean branch September 8, 2024 18:33
Copy link
Contributor

This issue is mentioned in release v1.9.1 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recordDeleteAfter parameter not being applied correctly
1 participant