Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn users about skipped tracks when reading or publishing #3753

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Sep 9, 2024

No description provided.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 68.68687% with 31 lines in your changes missing coverage. Please review.

Project coverage is 56.00%. Comparing base (8aedf1a) to head (d777a7c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocols/hls/from_stream.go 50.00% 10 Missing and 2 partials ⚠️
internal/recorder/format_fmp4.go 10.00% 7 Missing and 2 partials ⚠️
internal/recorder/format_mpegts.go 60.00% 3 Missing and 1 partial ⚠️
internal/staticsources/rtmp/source.go 0.00% 2 Missing and 1 partial ⚠️
internal/protocols/rtmp/to_stream.go 60.00% 2 Missing ⚠️
internal/protocols/hls/to_stream.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3753      +/-   ##
==========================================
- Coverage   56.03%   56.00%   -0.04%     
==========================================
  Files         194      194              
  Lines       19225    19291      +66     
==========================================
+ Hits        10773    10804      +31     
- Misses       7615     7646      +31     
- Partials      837      841       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the fix/track-warn branch 2 times, most recently from a05607e to e191f19 Compare September 11, 2024 20:57
@aler9 aler9 merged commit 471019f into main Sep 15, 2024
7 of 8 checks passed
@aler9 aler9 deleted the fix/track-warn branch September 15, 2024 17:28
Copy link
Contributor

This issue is mentioned in release v1.9.1 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant