Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: versionchooser: cleanup dangling docker images when starting up #1005

Merged
merged 1 commit into from
May 13, 2022
Merged

core: versionchooser: cleanup dangling docker images when starting up #1005

merged 1 commit into from
May 13, 2022

Conversation

Williangalvani
Copy link
Member

we should have a way of cleaning up until aio-libs/aiodocker#696 is closed.

rafaellehmkuhl
rafaellehmkuhl approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs the CI fix and I would also leave an issue open here to track the aio lib change.

patrickelectric
patrickelectric approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be free to merge if the developers don't fix the issue

@patrickelectric patrickelectric merged commit d605269 into bluerobotics:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaellehmkuhl rafaellehmkuhl rafaellehmkuhl approved these changes

@patrickelectric patrickelectric patrickelectric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Williangalvani @patrickelectric @rafaellehmkuhl