Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Autopilot manager: Add fallback for first available router in case of invalid preferred one #2933

Conversation

JoaoMario109
Copy link
Collaborator

No description provided.

@JoaoMario109 JoaoMario109 force-pushed the fallback-in-loading-fail branch 3 times, most recently from 5dcff3c to 2341753 Compare October 1, 2024 12:24
@JoaoMario109 JoaoMario109 marked this pull request as ready for review October 3, 2024 06:20
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this fallback when I was testing mavlink-server PR and went back to master without changing back to mavp2p, but now I'm not sure how to test it. The code seems fine to me.

@JoaoMario109
Copy link
Collaborator Author

JoaoMario109 commented Oct 7, 2024

I missed this fallback when I was testing mavlink-server PR and went back to master without changing back to mavp2p, but now I'm not sure how to test it. The code seems fine to me.

If want to test it, just go in file browser and edit the settings.json from autopilot manager in the configs, you can change proffered router to anything and see in the autopilot logs if it will fallback;

@patrickelectric
Copy link
Member

@JoaoMario109 can you rebase ?

* Make autopilot manager fallback to first avbailable router when
  unable to start current preferred router
@joaoantoniocardoso joaoantoniocardoso merged commit 05c99de into bluerobotics:master Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants