Add main frontend

[rafaellehmkuhl]

Main frontend for companion-docker

Setup is:

• Vue 2
• SASS (with dart-sass)
• Typescript
• PWA support
• Router (with history mode)
• Vuex
• Vuetify

Adds test job for installing and building the frontend project.

This fixes #207, although there are import considerations there we should open new issue for in the future (regarding dynamic plugins).

Image available for test under rafaellehmkuhl/companion-core:frontend

[patrickelectric]

The are some things that are conceptually wrong.
Files that are a size transformation should be created/generated by the build system, avoid unnecessary tracking and management of unnecessary files.
The patch is also missing a gitignore and dockerignore files, the first one is to ignore and help us as developers to avoid dealing with unnecessary noise under git diff, the second is important to avoid problems with docker cache system, check my comment for further explanation.
There is also PWA packages and some configuration files, but it's missing the configuration for service-worker.

I believe that is a good patch, but to get it merged we need to have at least a bare minimum correct structure and dependencies to avoid any pain for us in further development, once we hit the sweet spot of a good basic configuration for the typescript frontend we should be good to merge.

It's also failing in the CI.

[rafaellehmkuhl]

The are some things that are conceptually wrong.
Files that are a size transformation should be created/generated by the build system, avoid unnecessary tracking and management of unnecessary files.

Please, check my comment on your first review. Those files are not just size transformation. There's background and margins added in the process. That's the only solution, unless we want to learn how to use and add a cli-image-editor-like tool on our build because of the tracking of 3 images that are all together.

The patch is also missing a gitignore and dockerignore files, the first one is to ignore and help us as developers to avoid dealing with unnecessary noise under git diff, the second is important to avoid problems with docker cache system, check my comment for further explanation.

You've previously suggested that we should not have gitignore for node_modules folder. Have you changed your mind on that?
About the dockerignore, I will add one.

There is also PWA packages and some configuration files, but it's missing the configuration for service-worker.

It's not, like I've answered on the first review. Vue automatically adds a default service worker during build time. We only need to specify one if we want custom behavior.

It's also failing in the CI.

Yes, this is failing since we removed the dedicated eslintrc file, like you suggested (which I found is reasonable), but it's needed on the frontend folder during build time. Do you have any suggestion on that?

[patrickelectric]

suggested that we should not have gitignore for node_modules

Please link the commend, I said that dockerignore is missing and not that gitignore should not exist.

dedicated eslintrc file, like you suggested

As said, the file should not exist if you merge it with the project configuration. Check MGroundStation example

[rafaellehmkuhl]

Please link the commend, I said that dockerignore is missing and not that gitignore should not exist.

That was outside github, but ok

As said, the file should not exist if you merge it with the project configuration. Check MGroundStation example

You're not understanding. That's not the case with MGS. That's a build problem from the fact that the dockerfile is on a sub-folder with relation to the eslintrc file, so there's no way to copy.

I've found a possible solution disabling the eslint on build, though.

[Williangalvani]

Looking good so far.
27289a5 commit message is either missing "dockerfile" or has an extra colon

[rafaellehmkuhl]

The problem with the helper service is because it's fetching the backend through the latest path on the frontend, instead of the vX.Y path, like the other services.

For some strange reason, when this is done, the redirect URL is removing the /helper on the beggining of the URL, as can be seen in the image above.

As all other services are using v1.0 URLs for fetching, I moved this fetch on helper to v1.0 also and opened issue #344 to track this problem (inability to use /latestpaths on the frontends).

It was working before by a coincidence. It was the one that should not work, but the fact that it was on the root path (/) masked the problem.

@Williangalvani this seems to be related to nginx. Do you have any idea on what may be happening?

[patrickelectric]

LGTM