Add endpoint that follows mavlink2rest #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaoantoniocardoso
requested changes
Sep 20, 2024
| DATA.messages | ||
| .lock() | ||
| .unwrap() | ||
| .update(MAVLinkMessage { header, message }); |
There was a problem hiding this comment.
Suggested change
| .update(MAVLinkMessage { header, message }); | |
| .update(Arc::new(MAVLinkMessage { header, message })); |
There was a problem hiding this comment.
Why the arc here ?
There was a problem hiding this comment.
We don't need it (referring to using Arc here). I was trying to make the clone cheaper if we couldn't avoid them, but we can almost completely avoid them, making the clone only when inserting, not when updating.
patrickelectric
force-pushed
the
rest-more
branch
2 times, most recently
from
25f6b15
to
c5b865e
Compare
Merged
patrickelectric
force-pushed
the
rest-more
branch
from
c5b865e
to
c7168ac
Compare
joaoantoniocardoso
requested changes
Oct 2, 2024
| DATA.messages | ||
| .lock() | ||
| .unwrap() | ||
| .update(MAVLinkMessage { header, message }); |
There was a problem hiding this comment.
We don't need it (referring to using Arc here). I was trying to make the clone cheaper if we couldn't avoid them, but we can almost completely avoid them, making the clone only when inserting, not when updating.
patrickelectric
force-pushed
the
rest-more
branch
3 times, most recently
from
ceb154f
to
e16cecd
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
Create path for mavlink2rest Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
rest-more
branch
from
e16cecd
to
196b8a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.