sensor: ping: Add check to ignore invalid firmware files

Signed-off-by: Patrick José Pereira <[email protected]>
bluerobotics · Jun 11, 2024 · ac3817e · ac3817e
1 parent 2227c49
commit ac3817e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/sensor/ping.cpp b/src/sensor/ping.cpp
@@ -513,6 +513,10 @@ void Ping::checkNewFirmwareInGitHubPayload(const QJsonDocument& jsonDocument)
         // Get version from Ping(\d|)[_|-]V(major).(patch)*.hex where (major).(patch) is <version>
         static const QRegularExpression versionRegex(QStringLiteral(R"(Ping(\d|)[_|-]V(?<version>\d+\.\d+).*\.hex)"));
         auto filePayloadVersion = versionRegex.match(filePayload["name"].toString()).captured("version").toFloat();
+        if (filePayloadVersion <= 0) {
+            qCWarning(PING_PROTOCOL_PING) << "Invalid version:" << filePayload["name"].toString();
+            continue;
+        }
         _firmwares[filePayload["name"].toString()] = filePayload["download_url"].toString();
 
         if (filePayloadVersion > lastVersionAvailable) {