-
Notifications
You must be signed in to change notification settings - Fork 389
Reduce warm lambda processing time and add SAM framework #112
base: master
Are you sure you want to change the base?
Conversation
|
1 similar comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems very sensible and useful PR
Hi folks, I am currently testing this and the PR requires So to
Is required. I tried to use a virtualenv/pipenv to install this, but this is not picked up by the Would it be a better option to include Regards, |
must still verify if extra virus definitions get pulled form S3 from bluesentry#112
must still verify if extra virus definitions get pulled form S3 from bluesentry#112
must still verify if extra virus definitions get pulled form S3 from bluesentry#112
Hi, we would like to propose the following changes to your repo:
Performance optimisation
clamscan
loads virus databases each time it is executed. The actual scan operation takes an order of magnitude less time to complete.By starting ClamAV as a daemon and loading the virus databases only once, the execution time on warm lambdas improves drammatically:
Deployment optimisation
Managing the deployments and AWS resources and policies manually is hard to track and prone to human error. Infrastructure as code greatly reduces the risk of resource management and traceability.
The deployment process described in the README.md is written in a template file that can be deployed via SAM.
This PR can be split into two if necessary.
Thank you for building this tool 🙏