This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Explicit failed status and increased error handling #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the ClamAV exec fails for any reason the script was simply raising an exception and dying. This causes confusion for both users and admins and could lead to endless re-scanning for files that would never complete.
This PR does a few things:
AV_STATUS_FAILED
status variable to explicitly denote that a scan failed to completescan.py
slambda_handler
method to reduce size and so that pieces of it can be re-used. The new methods areremove_file
anddownload_clamav_databases