This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--prefix
argument toscan_bucket.py
anddisplay_infected.py
to limit the objects considered for each.For buckets with many (>100,000) the
scan_bucket.py
anddisplay_infected.py
scripts can incur long running times and non-negligible API costs to iterate an entire bucket. The--prefix
option passes a string to the ListObjectsV2 Prefix parameter which limits the objects to iterate and consider.Note: the long runtime/incurred costs issue remains present in the existing
--limit
argument as it currently iterates the entire bucket before trimming the returned objects with a Python slice. I'm making these patches on a contract job so I don't have time to fix the pagination logic for this issue. Please advise if you'd like a separate issue to track.