Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: make the timestamps part of the payload optional #173

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tacaswell
Copy link
Contributor

Description

Makes 'timestamps' option in the event schema, event page schema, and compose_* APIs.

Motivation and Context

As discussed on today pilot call, the 'timestamps' entry makes a lot of sense when the ultimate source of the data is a control systems (and fundamentally asynchronous) but makes much less sense for the output of data analysis.

This is the minimal change to event model to allow this. There will need to be a companion change to databroker to cope with data that may not have timestamps.

@dylanmcreynolds
Copy link
Contributor

Have you considered adding a field to schemas (and their documents) for "schema_version" so that people from the future can easily track which schema a particular instance was written against? This is a nice recommendation from the mongo folks (https://www.mongodb.com/blog/post/building-with-patterns-the-schema-versioning-pattern). It seems to me that this same logic would apply to non-mongo serializations as well.

Granted, this particular schema change is easy to imply..."oh, there's not a datastamp? must have been after that was optional." Making it explicit might still be nice.

@danielballan
Copy link
Member

Related to #3

Thanks for the Mongo reference, @dylanmcreynolds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants