Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specs should be able to get their dimensionality information #88

Open
DiamondJoseph opened this issue Aug 29, 2023 · 0 comments · May be fixed by #89
Open

Specs should be able to get their dimensionality information #88

DiamondJoseph opened this issue Aug 29, 2023 · 0 comments · May be fixed by #89

Comments

@DiamondJoseph
Copy link
Contributor

Currently

Spiral.axes() -> ["y", "x"]

and

Product(Line, Line).axes() -> ["x", "y"]

But Spiral has 1 dimension in 2 axes ("x", "y") and a grid has 2 dimensions in 2 axes ("x"), ("y").
DiamondJoseph added a commit that referenced this issue Aug 30, 2023
@DiamondJoseph
Add dimensionality information to Specs
f5fca18 
- Closes #88
- Add axes, shape and snaked information in (usually) non-points-calculating method.
- Deprecate Spec.axes: did not respect Frame information
- Deprecate Spec.shape: Called calculate() and discarded information
@DiamondJoseph DiamondJoseph linked a pull request Aug 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dimensionality information to Specs bluesky/scanspec
1 participant
@DiamondJoseph