Remove the need for uses_tagged_union deco #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present we support people adding to the list of Specs after importing the service. This requires a uses_tagged_union decorator on any BaseModel that references a Spec. We cannot currently think of a use case for Specs being implemented outside of scanspec.specs, so removing this requirement means we can ditch the decorator. It also makes the docs (next PR) easier to write: - Put your specs in src/scanspec/specs.py - Release a new version - Update both blueapi and the scanspec service to use that new version
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
- Coverage 96.05% 95.89% -0.17%
==========================================
Files 9 9
Lines 939 926 -13
==========================================
- Hits 902 888 -14
- Misses 37 38 +1 ☔ View full report in Codecov by Sentry. |
|
Blueapi requires being able to make BaseModels with fields that are Specs/Regions as we create BaseModels for the signature of plan functions. This looks from the tests that remain that this is still supported. But if we're acknowledging that all Spec implementations will be in this library we can just make a hardcoded |
DiamondJoseph
approved these changes
Aug 28, 2024
ZohebShaikh
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present we support people adding to the list of Specs after importing the service. This requires a uses_tagged_union decorator on any BaseModel that references a Spec. We cannot currently think of a use case for Specs being implemented outside of scanspec.specs, so removing this requirement means we can ditch the decorator. It also makes the docs (next PR) easier to write: