Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use FastAPI status constants #650

Closed
danielballan opened this issue Feb 8, 2024 · 1 comment · Fixed by #694
Closed

Refactor to use FastAPI status constants #650

danielballan opened this issue Feb 8, 2024 · 1 comment · Fixed by #694
Assignees
Labels
good first issue Good for newcomers

Comments

@danielballan
Copy link
Member

Suggested by @DiamondJoseph (and I agree) we should use human-readable status code constants. https://fastapi.tiangolo.com/tutorial/response-status-code/#shortcut-to-remember-the-names

In fact these are defined in starlette so we can import them from there.

@padraic-shafer
Copy link
Contributor

Amen. I use this on other projects, and appreciate the clarity in the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants