Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client requirements should include starlette #711

Closed
pbeaucage opened this issue Apr 8, 2024 · 1 comment · Fixed by #716
Closed

client requirements should include starlette #711

pbeaucage opened this issue Apr 8, 2024 · 1 comment · Fixed by #716

Comments

@pbeaucage
Copy link
Contributor

pbeaucage commented Apr 8, 2024

#694 and #650 added starlette status constants to the client, but starlette never made it into the client requirements causing an import error if you only install tiled[client].

I believe it should be in both [client] and [minimal-client].

A broader question as this has happened before: could we add a CI test that installs the package with just [minimal-client] or [client] and verifies (to first order) that the package imports, and ideally that a basic client function test passes, maybe against the public test server? This would likely have to be its own GHA/non-pytest script since afaik there is no environment control at the pytest level.

@danielballan
Copy link
Member

Good call @pbeaucage! 👍 for a test with client and minimal-client deps only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants