Fix bug in .join_cover() and bug in ContiguousMut #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
force-pushed
the
fix-join-cover
branch
from
3362c97
to
e22012b
Compare
This is an API break, because the previous proof was unsound. Like the bug points out, in join cover we take (self, other) and extend self until the end of other; if other ends before self, we don't gain any "cover" from other, and thus the proof is the same as self (making the method quite useless). Added traits for checking the proof value in dynamic code, since completest really doesn't work well right now.
This is the only sound way to derive proper raw mut pointers from slices.
bluss
force-pushed
the
fix-join-cover
branch
from
e22012b
to
2aa7b97
Compare
bluss
changed the title
bluss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.join_cover() changes so that it reuses the proof of the first parameter; this is an API break but the proof was wrong, so it's only good.
Fix ContiguousMut methods to use a
&mutreceiver for the mutable raw pointer methods. This is an API break, but the old signature was always wrong.Fixes #11
Fixes #12