Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if the guard is not assigned to a variable and is dropped immedi… #37

Merged
merged 2 commits into from
May 1, 2022
Merged

Warn if the guard is not assigned to a variable and is dropped immedi… #37

merged 2 commits into from
May 1, 2022

Conversation

sergey-v-galtsev
Copy link
Contributor

…ately instead of at the scope's end.

@bluss
Copy link
Owner

bluss commented May 1, 2022

Thanks, this makes sense. ScopeGuard::with_strategy could get the same attribute.

@sergey-v-galtsev
Copy link
Contributor Author

Good point, added there too.

@bluss bluss merged commit c6e9d49 into bluss:master May 1, 2022
@sergey-v-galtsev sergey-v-galtsev deleted the warn_if_the_guard_is_dropped_immediately branch May 1, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergey-v-galtsev @bluss