Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gensim Author-Topic-Model support #161

Closed
wants to merge 3 commits into from
Closed

Conversation

jonaschn
Copy link
Contributor

@jonaschn jonaschn commented Feb 10, 2020

This PR adds the ability to use the Author-Topic Model in the same way, the LDA model is used.
It does not visualize the authors but only (as expected by pyLDAvis) the topic-term distributions.
See #112 and #84 for more details.

@bmabey
Copy link
Owner

bmabey commented Dec 2, 2020

Sorry, I am just seeing this. It looks like there are conflicts due to some recent PRs that have been merged. Would you still like to see this PR merged? If so would you mind resolving the conflicts? Thanks!

@jonaschn
Copy link
Contributor Author

@bmabey Thanks for asking. Sure, I would like to see this PR merged. I resolved the conflicts.
However, I am not sure if the value of the passed (and required) parameter rhot is appropriate.
@tmthyjames proposed this value.
I asked the devs of gensim what is appropriate: piskvorky/gensim#1766

@msusol
Copy link
Collaborator

msusol commented Mar 18, 2021

I have a new vs 3.3.0 ready to push to git, please hold until after this version is official.

@msusol
Copy link
Collaborator

msusol commented Mar 22, 2021

Notice: I had to rename gensim.py to gensim_models.py so you will need to reapply your fix and retest.

@msusol
Copy link
Collaborator

msusol commented Apr 20, 2021

Please resolve the conflicts before I can complete the PR.

@jonaschn
Copy link
Contributor Author

The proposed solution in #112 works only if there is only one author per document (the second test case).
I still need to figure out how to support other scenarios as well.

@msusol msusol closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants