Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Tensorboard works in docker #1137

Merged
merged 4 commits into from
Jul 9, 2023
Merged

Let Tensorboard works in docker #1137

merged 4 commits into from
Jul 9, 2023

Conversation

jim60105
Copy link
Contributor

@jim60105 jim60105 commented Jul 8, 2023

Thank you for creating this excellent tool. 👍

I encountered an issue with Tensorboard not starting while using Docker, and I have resolved it.

I modified the startup parameters of Tensorboard to work in a Docker environment and skipped calling webbrowser.open() within Docker.

The PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION environment variable is used by the WHAT-IF Tool. I encountered this issue and found a workaround here. Although I have no idea what the WHAT-IF Tool is for.

This PR has only been tested in docker as I exclusively used docker (with Windows Docker desktop) to run kohya_ss.
Therefore, further testing and validation on other platforms is necessary.

Thanks

@bmaltais bmaltais changed the base branch from master to dev2 July 9, 2023 17:33
@bmaltais
Copy link
Owner

bmaltais commented Jul 9, 2023

I will merge the changes into the dev2 branch to validate that all still work fin under windows

@bmaltais bmaltais merged commit 3bb308b into bmaltais:dev2 Jul 9, 2023
@bmaltais
Copy link
Owner

bmaltais commented Jul 9, 2023

That PR broke the solution on windows, I will revert it. Need a better way to detect when it run in docker cause right now it will no longet open the browser on windows.

@jim60105
Copy link
Contributor Author

jim60105 commented Jul 11, 2023

@bmaltais I beleve that's not a related issue though, since I saw community talking about this issue #1139 before my PR.
Please feel free to pick this commit again when you fix that problem.

@bmaltais bmaltais mentioned this pull request Jul 11, 2023
gesen2egee pushed a commit to gesen2egee/kohya_ss that referenced this pull request Feb 27, 2024
gesen2egee pushed a commit to gesen2egee/kohya_ss that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants