Max norm adjust #1272
Merged
Max norm adjust #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. Merged into dev2 and will merge in master for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the maximum value for the max norm in the LoRA tab. As mentioned in the PR, the value might also be set higher than 1, but is currently the maximum allowed in the GUI due to the nature of the slider component. (The CLI allows for higher numbers).
@AI-Casanova added, that a value of 10 is never used, which i deemed to be a high enough value for the slider.
I also added a bit more info for the "inverted" logic of the max norm to be understood by newcomers.