Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that it fails to load a VAE #1688

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

nattoheaven
Copy link
Contributor

There is a bug that the vae variable in run_cmd_advanced_training is not evaluated for run_cmd.
This PR fixes it.

@bmaltais
Copy link
Owner

Darn... I already fixed it last night in the dev2 branch. Thank you for providing the PR to fix it also ;-)

@bmaltais
Copy link
Owner

Wait... your fix is actually for another issue related to that... Mine was to fix the loading of the vae parameter from the json that returned an empty path instead of the vae path... OK, I will merge it. Good catch.

@bmaltais bmaltais changed the base branch from master to dev2 November 16, 2023 15:59
@bmaltais bmaltais merged commit 6134f9c into bmaltais:dev2 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants