Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing import in BLIP captioning #1821

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Fix missing import in BLIP captioning #1821

merged 2 commits into from
Jan 3, 2024

Conversation

paboum
Copy link
Contributor

@paboum paboum commented Dec 30, 2023

Resolving #1820

@oumad
Copy link

oumad commented Dec 30, 2023

I was about to fork the project to do this, thank you,
I also checked in sd-scripts they don't have this issue. It's only recently in this repo, after the merge, the url check was added in finetune/make_captions.py

        if not is_url(args.caption_weights) and not os.path.isfile(args.caption_weights):
            args.caption_weights = os.path.join("..", args.caption_weights)

but not in the imports.

from blip.blip import blip_decoder

@paboum
Copy link
Contributor Author

paboum commented Dec 30, 2023

Seems to have been properly merged in d653e59 but later lost.
Perhaps @CjangCjengh could see why.

@bmaltais
Copy link
Owner

bmaltais commented Jan 3, 2024

Oh... somehow it was removed from my side... OK, I will merge this in the dev branch. checkout that branch to get the updated code.

@bmaltais bmaltais changed the base branch from master to dev January 3, 2024 01:09
@bmaltais bmaltais merged commit a2eed05 into bmaltais:dev Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants