Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor kohya_gui parts #2017

Merged
merged 6 commits into from
Mar 1, 2024
Merged

refactor kohya_gui parts #2017

merged 6 commits into from
Mar 1, 2024

Conversation

wkpark
Copy link
Contributor

@wkpark wkpark commented Feb 27, 2024

Recent updates have brought it almost synced with the original kohya's repo.
This PR splitting/refactoring the structure of the code a bit to make it more manageable/upstreamable.

And then, it's easy to support both the sd-webui extension and standalone script.


and this is a quick and dirty sd-webui extension wkpark/sd-scripts#1

@bmaltais
Copy link
Owner

bmaltais commented Mar 1, 2024

This look awesome, I will merge it to a new branch based on dev to test it out and assess it. Looking forward to merge it to the dev branch

@bmaltais bmaltais changed the base branch from master to dev-refactor March 1, 2024 21:30
@bmaltais
Copy link
Owner

bmaltais commented Mar 1, 2024

I discovered a small issue... the stop training button no longer appear to actually stop the training... Probably something minor. Would you be able to attend to it? Otherwise everything look pretty much good to go with just one minor other bug I was able to attend to. The windows validation python script library call needed an adjustment to point to the new kohya_gui folder.

EDIT:

Nah, that stop issue was my own wrongdoing... I was on the wrong tab when I hit the stop training... so obviously it could not find the dreambooth process when what I tested was a LoRA ;-)

OK, I will merge this to dev... Many thanks for this.

Now I am thinking that all those _gui.py files in the root of the repo should probably move under the kohya_gui folder...

What do you think?

@bmaltais bmaltais changed the base branch from dev-refactor to dev March 1, 2024 21:52
@bmaltais bmaltais merged commit 9eb335b into bmaltais:dev Mar 1, 2024
1 check failed
@wkpark
Copy link
Contributor Author

wkpark commented Mar 2, 2024

Thank you for all your hard work!

I discovered a small issue... the stop training button no longer appear to actually stop the training... Probably something minor. Would you be able to attend to it? Otherwise everything look pretty much good to go with just one minor other bug I was able to attend to. The windows validation python script library call needed an adjustment to point to the new kohya_gui folder.

EDIT:

Nah, that stop issue was my own wrongdoing... I was on the wrong tab when I hit the stop training... so obviously it could not find the dreambooth process when what I tested was a LoRA ;-)

OK, I will merge this to dev... Many thanks for this.

Now I am thinking that all those _gui.py files in the root of the repo should probably move under the kohya_gui folder...

What do you think?

Yes we can move the wrapper frontends to the kohya_gui/ folder but I've left the *_gui.py frontends for those who are confused by the change.

@wkpark wkpark deleted the kohya_gui branch March 2, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants