Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] UI fix/cleanup #2033

Merged
merged 13 commits into from
Mar 7, 2024
Merged

[UI] UI fix/cleanup #2033

merged 13 commits into from
Mar 7, 2024

Conversation

wkpark
Copy link
Contributor

@wkpark wkpark commented Mar 4, 2024

WIP

  • unify Quick Pick + custom model selection into gr.Dropdown()
  • add list_dirs(), list_files() for more easy dir/file selection for headless
  • use gr.Accordion() to show all settings in one page
  • always show model + training image folder + output name + minimal default settings

misc fixes:

  • elem_classes=["tool"] added for icons for sd-webui.
  • copy create_refresh_button() from sd-webui

we need to discuss some default_* settings, for example:

  • default_train_data_dir : data/
  • default_output_dir : outputs/
  • default_logging_dir: logs/
  • default_reg_data_dir: data/

some extra notes:

  • vae : e.g) models/VAE in sd-webui
  • models: e.g) models/Stable-diffusion in sd-webui
  • Lora: e.g) models/Lora in sd-webui
  • embeddings: e.g) embeddings/ in sd-webui

screenshot

image

headless + with dark theme
image

@wkpark wkpark marked this pull request as draft March 4, 2024 00:35
@bmaltais
Copy link
Owner

bmaltais commented Mar 4, 2024

This look great. This next release will see some major upgrade ;-) I like it. This will be some major rework of the GUI. It will make life easier for many users.

@bmaltais
Copy link
Owner

bmaltais commented Mar 4, 2024

As far as defaults directory go this is tricky. We can try to set some values. The ones proposed make sense.

@bmaltais
Copy link
Owner

bmaltais commented Mar 4, 2024

I have been playing with the updated code so far and the UI look really slick. I like the rework you have done. One thing I noticed, at the moment the default location for everything appear to be in the root of the repo... I wonder if this should not be changed to a folder that could be ignored within the repo... for example, say we follow the comfyui output folder name... this could become the default output folder for users model output...

I know I am getting ahead but perhaps this could be set via a parameter that could be kept with the GUI... so if a user would rather output his LoRA under E:\loras and his Finetune under e:\models it would be great... something for the future... but something I think your new UI style might support well.

Thanks for all this work by the way. I really appreciate the help to make the GUI better for everyone and more accessible as e future extension of a1111.

@wkpark wkpark force-pushed the dev-fix-ui branch 2 times, most recently from 1ed9cf0 to 35303b7 Compare March 4, 2024 10:48
@wkpark
Copy link
Contributor Author

wkpark commented Mar 4, 2024

more fixes + partially squashed.

 * unify Quick Pick + custom model selection into gr.Dropdown()
 * add list_dirs(), list_files()
 * use gr.Accordion()
 * always show model + training image folder + output name + minimal default settings
 * do not show hidden files
 * clean up list_*()
@wkpark
Copy link
Contributor Author

wkpark commented Mar 6, 2024

update all remaining UIs using list_dirs(), list_files() + create_refresh_button()

@wkpark wkpark marked this pull request as ready for review March 6, 2024 05:22
@bmaltais bmaltais merged commit e59a98c into bmaltais:dev-pure Mar 7, 2024
1 check failed
@wkpark wkpark deleted the dev-fix-ui branch March 8, 2024 18:37
@Kadah
Copy link

Kadah commented Mar 12, 2024

The new UI is not working with my astigmatism and is going to trigger a full on migrine if I try to use it longer than the few seconds I was on it after updating. Any way to get the previous text style back or whatever other major change that could be the problem?

I can't actually look at it long enough to tell whats different or specifically causing this rare problem on certain UI designs. Literally was only on it for about 30 seconds trying to find there the config panel moved to and had started to loose the use of one eye and the other was going blurry. I need to need to be able to function today, so I stopped there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants