chore(docker): adjust Dockerfile layers to improve build cache design #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it can keep git working tree clean when user has dataset files. Signed-off-by: 陳鈞 <[email protected]>
- Remove Docker LABEL related metadata and ARG for UID, VERSION, RELEASE from the beginning of the Dockerfile. - Add NVIDIA environment settings to make visible devices and driver capabilities available. - Add ARG UID back and modify user creation command accordingly. - Make use of hard links (with `--link`) for license and code copy commands to optimize use of space. - Reposition WORKDIR and ARG declarations for VERSION and RELEASE towards the end of the Dockerfile. - Attach metadata labels like name, vendor, url, version, release, display name, summary, and description at the end of the Dockerfile, instead of the beginning. Signed-off-by: 陳鈞 <[email protected]>
Clear special settings that were used in the old image. Signed-off-by: 陳鈞 <[email protected]>
Signed-off-by: 陳鈞 <[email protected]>
Signed-off-by: 陳鈞 <[email protected]>
Signed-off-by: 陳鈞 <[email protected]>
|
#2103 I open an issue about regularization and config folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the dockerfile to enhance the reusability of layers, enabling users to use more existing layers during application updates, resulting in savings in disk space and build time.
In fact, there will only be some minor differences, since now this project does not bring in the version and release number when building docker images (which should be done in CI).
And I organized the
datasetdirectory structure and bind it to the default path to ensure that the default directory logic implemented in this project can be applied in the docker environment.Notice that I bind the regularization images directory with the name
regularizationand the configuration files directory with the nameconfig, which does not align with the project's default settings.At present, both the regularization directory and the training images directory share the same default directory
data. In my opinion, it would be better to distinguish between them.As for the config directory, it currently default to
None. I suggest assign and init it just like other directories does.