Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v23.0.13 #2127

Merged
merged 1 commit into from
Mar 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v23.0.12
v23.0.13
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ The GUI allows you to set the training parameters and generate and run the requi
- [No module called tkinter](#no-module-called-tkinter)
- [SDXL training](#sdxl-training)
- [Change History](#change-history)
- [2024/03/13 (v23.0.13)](#20240313-v23013)
- [2024/03/16 (v23.0.12)](#20240316-v23012)
- [New Features \& Improvements](#new-features--improvements)
- [Software Updates](#software-updates)
Expand Down Expand Up @@ -379,6 +380,10 @@ The documentation in this section will be moved to a separate document later.

## Change History

### 2024/03/13 (v23.0.13)

- Fix issue with image samples.

### 2024/03/16 (v23.0.12)

#### New Features & Improvements
Expand Down
12 changes: 9 additions & 3 deletions kohya_gui/class_sample_images.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,13 @@ def run_cmd_sample(

run_cmd = ''

if sample_every_n_epochs == sample_every_n_steps == '0':
if sample_every_n_epochs is None:
sample_every_n_epochs = 0

if sample_every_n_steps is None:
sample_every_n_steps = 0

if sample_every_n_epochs == sample_every_n_steps == 0:
return run_cmd

# Create the prompt file and get its path
Expand All @@ -55,10 +61,10 @@ def run_cmd_sample(
run_cmd += f' --sample_sampler={sample_sampler}'
run_cmd += f' --sample_prompts="{sample_prompts_path}"'

if sample_every_n_epochs != '0':
if sample_every_n_epochs != 0:
run_cmd += f' --sample_every_n_epochs={sample_every_n_epochs}'

if sample_every_n_steps != '0':
if sample_every_n_steps != 0:
run_cmd += f' --sample_every_n_steps={sample_every_n_steps}'

return run_cmd
Expand Down