Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with vae file path validation #2454

Merged
merged 1 commit into from
May 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v24.1.0
v24.1.1
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ The GUI allows you to set the training parameters and generate and run the requi
- [SDXL training](#sdxl-training)
- [Masked loss](#masked-loss)
- [Change History](#change-history)
- [v24.1.1](#v2411)
- [v24.1.0](#v2410)

## 🦒 Colab
Expand Down Expand Up @@ -441,6 +442,10 @@ ControlNet dataset is used to specify the mask. The mask images should be the RG

## Change History

### v24.1.1

- Fix small issue with VAE file path validation

### v24.1.0

- To ensure cross-platform compatibility and security, the GUI now defaults to using "shell=False" when running subprocesses. This is based on documentation and should not cause issues on most platforms. However, some users have reported issues on specific platforms such as runpod and colab. PLease open an issue if you encounter any issues.
Expand Down
2 changes: 1 addition & 1 deletion kohya_gui/dreambooth_gui.py
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ def train_model(
if not validate_folder_path(train_data_dir):
return TRAIN_BUTTON_VISIBLE

if not validate_folder_path(vae):
if not validate_file_path(vae):
return TRAIN_BUTTON_VISIBLE
#
# End of path validation
Expand Down
2 changes: 1 addition & 1 deletion kohya_gui/lora_gui.py
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ def train_model(
if not validate_folder_path(train_data_dir):
return TRAIN_BUTTON_VISIBLE

if not validate_folder_path(vae):
if not validate_file_path(vae):
return TRAIN_BUTTON_VISIBLE

#
Expand Down
2 changes: 1 addition & 1 deletion kohya_gui/textual_inversion_gui.py
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ def train_model(
if not validate_folder_path(train_data_dir):
return TRAIN_BUTTON_VISIBLE

if not validate_folder_path(vae):
if not validate_file_path(vae):
return TRAIN_BUTTON_VISIBLE

#
Expand Down
49 changes: 39 additions & 10 deletions test/config/finetune-AdamW-toml.json
Original file line number Diff line number Diff line change
@@ -1,51 +1,76 @@
{
"adaptive_noise_scale": 0,
"additional_parameters": "",
"async_upload": false,
"batch_size": "8",
"block_lr": "",
"bucket_no_upscale": false,
"bucket_reso_steps": 1,
"cache_latents": true,
"cache_latents_to_disk": false,
"caption_dropout_every_n_epochs": 0.0,
"caption_dropout_every_n_epochs": 0,
"caption_dropout_rate": 0,
"caption_extension": ".txt",
"caption_metadata_filename": "meta-1_cap.json",
"clip_skip": 1,
"color_aug": false,
"create_buckets": false,
"create_caption": true,
"dataset_config": "D:/kohya_ss/test/config/dataset-finetune.toml",
"dataset_config": "./test/config/dataset-finetune.toml",
"dataset_repeats": "50",
"debiased_estimation_loss": false,
"dynamo_backend": "no",
"dynamo_mode": "default",
"dynamo_use_dynamic": false,
"dynamo_use_fullgraph": false,
"epoch": 2,
"extra_accelerate_launch_args": "",
"flip_aug": false,
"full_bf16": false,
"full_fp16": false,
"full_path": true,
"gpu_ids": "",
"gradient_accumulation_steps": 1.0,
"gradient_accumulation_steps": 1,
"gradient_checkpointing": false,
"huber_c": 0.1,
"huber_schedule": "snr",
"huggingface_path_in_repo": "",
"huggingface_repo_id": "",
"huggingface_repo_type": "",
"huggingface_repo_visibility": "",
"huggingface_token": "",
"image_folder": "",
"ip_noise_gamma": 0,
"ip_noise_gamma_random_strength": false,
"keep_tokens": 0,
"latent_metadata_filename": "meta-1_lat.json",
"learning_rate": 1e-05,
"learning_rate_te": 5e-06,
"learning_rate_te1": 5e-06,
"learning_rate_te2": 0.0,
"learning_rate_te2": 0,
"log_tracker_config": "",
"log_tracker_name": "",
"log_with": "",
"logging_dir": "./test/ft",
"loss_type": "l2",
"lr_scheduler": "cosine_with_restarts",
"lr_scheduler_args": "",
"lr_warmup": 10,
"main_process_port": 0,
"masked_loss": false,
"max_bucket_reso": "1024",
"max_data_loader_n_workers": "0",
"max_data_loader_n_workers": 0,
"max_resolution": "512,512",
"max_timestep": 1000,
"max_token_length": "75",
"max_train_epochs": "",
"max_train_steps": "20",
"max_token_length": 75,
"max_train_epochs": 0,
"max_train_steps": 20,
"mem_eff_attn": false,
"metadata_author": "",
"metadata_description": "",
"metadata_license": "",
"metadata_tags": "",
"metadata_title": "",
"min_bucket_reso": "256",
"min_snr_gamma": 0,
"min_timestep": 0,
Expand All @@ -55,6 +80,7 @@
"multires_noise_discount": 0,
"multires_noise_iterations": 0,
"noise_offset": 0,
"noise_offset_random_strength": false,
"noise_offset_type": "Original",
"num_cpu_threads_per_process": 2,
"num_machines": 1,
Expand All @@ -67,28 +93,31 @@
"pretrained_model_name_or_path": "runwayml/stable-diffusion-v1-5",
"random_crop": false,
"resume": "",
"resume_from_huggingface": "",
"sample_every_n_epochs": 0,
"sample_every_n_steps": 0,
"sample_prompts": "",
"sample_sampler": "euler_a",
"save_as_bool": false,
"save_every_n_epochs": 1,
"save_every_n_steps": 0,
"save_last_n_steps": 0,
"save_last_n_steps_state": 0,
"save_model_as": "safetensors",
"save_precision": "bf16",
"save_state": false,
"save_state_on_train_end": false,
"save_state_to_huggingface": false,
"scale_v_pred_loss_like_noise_pred": false,
"sdxl_cache_text_encoder_outputs": false,
"sdxl_checkbox": false,
"sdxl_no_half_vae": false,
"seed": "1234",
"seed": 1234,
"shuffle_caption": false,
"train_batch_size": 4,
"train_dir": "./test",
"train_text_encoder": true,
"use_latent_files": "No",
"use_wandb": false,
"v2": false,
"v_parameterization": false,
"v_pred_like_loss": 0,
Expand Down
Loading