Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup script for ubuntu users #288

Merged
merged 16 commits into from
Mar 4, 2023
Merged

Conversation

devNegative-asm
Copy link
Contributor

Creates a script which when run in Ubuntu, installs necessary dependencies and changes the accelerate commands to be compatible with bash.

Alternatively, lines 12-27 from ubuntu_setup.sh can be removed if this is put onto another branch where their changes to the source are visible (I recommend this).

@bmaltais
Copy link
Owner

bmaltais commented Mar 4, 2023

Great stuff. Does it run pretty well without modifications to the python code? I have not tested it myself... but if it does this is awesome!

@bmaltais
Copy link
Owner

bmaltais commented Mar 4, 2023

I think deleting the .bat and .ps1 files will cause serious isssues with git pull commands. I suggest to keep them and simply add the .sh files to the repo... that way linux and windows users can use the same code base.

Can you update the PR with this change? I will merge it into the dev branch after.

Fix for LoCon sliders visibility
Fix again the custom model config load
@devNegative-asm
Copy link
Contributor Author

When I tried, the commands as generated by python don't work on linux. I'll combine this with #272 and update the PR.

@devNegative-asm
Copy link
Contributor Author

I made as much of it work with ubuntu as I could test at the moment. It should in theory still work on windows, but I'm unable to test that.

@bmaltais
Copy link
Owner

bmaltais commented Mar 4, 2023

Changes look good. I am doing a quick test and all appear to work so far. I will merge it to dev to test some more and then to master. Noce contribution! I am sure you will make many linus users happy.

@bmaltais bmaltais changed the base branch from master to dev March 4, 2023 22:58
@bmaltais bmaltais merged commit f903753 into bmaltais:dev Mar 4, 2023
Cauldrath pushed a commit to Cauldrath/kohya_ss that referenced this pull request Apr 5, 2023
sample images with weight and no length limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants