Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup/upgrade batch files #496

Merged
merged 4 commits into from
Apr 1, 2023
Merged

Conversation

missionfloyd
Copy link
Contributor

Greatly simplifies installation on Windows.

@jstayco
Copy link
Contributor

jstayco commented Mar 31, 2023

@bmaltais I had planned on giving the PowerShell installation stuff and README section the same treatment as macOS once I wrapped up current efforts. I think PowerShell is the way to go for the vast majority of people, but batch files are still good for people in high security environments or where they don't have the ability to run PowerShell scripts at all.

@missionfloyd This looks nice! If you want to make it more portable you can grab the directory where the script lives like this

# This gets the script directory.
SET path=%~dp0

# This removes the trailing slash if needed.
echo %path:~0,-1%

then use commandgit -C %path% _____. Then you can fix all the paths referenced in your batch files to prepend that. That way you don't have to cd to the folder to use it. You could be in C:\Users\me\Desktop and run the command "C:\Users\me\Programs\kohya_ss\update.bat" for example and it would work fine because all of your paths are relative to the script and not the user.

@bmaltais
Copy link
Owner

bmaltais commented Apr 1, 2023

Look ready to implement to me... do you want to add anything else?

@missionfloyd
Copy link
Contributor Author

I think it's good to go.

@bmaltais bmaltais changed the base branch from master to dev April 1, 2023 02:23
@bmaltais
Copy link
Owner

bmaltais commented Apr 1, 2023

Merging to dev for next release and testing. Many thanks

@bmaltais bmaltais merged commit 538752c into bmaltais:dev Apr 1, 2023
@bmaltais bmaltais mentioned this pull request Apr 1, 2023
@missionfloyd missionfloyd deleted the setup-batch branch April 3, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants