Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weights & biases UI options #720

Merged
merged 5 commits into from
May 5, 2023

Conversation

x-CK-x
Copy link
Contributor

@x-CK-x x-CK-x commented May 5, 2023

I have added the option for the user to put the wandb api key in a textbox under the advanced configuration dropdown and a checkbox to toggle for using wandb logging.

bmaltais and others added 3 commits May 5, 2023 07:30
I have added the option for the user to put the wandb api key in a textbox under the advanced configuration dropdown and a checkbox to toggle for using wandb logging.
I have added the option for the user to put the wandb api key in a textbox under the advanced configuration dropdown and a checkbox to toggle for using wandb logging.
@bmaltais
Copy link
Owner

bmaltais commented May 5, 2023

Nice idea. I see you did not add the change to the textual_inversion_gui.py file. Is it because that trainer does not support the option?

@x-CK-x
Copy link
Contributor Author

x-CK-x commented May 5, 2023

My apologies. I forgot it when uploading. Just added.

@bmaltais
Copy link
Owner

bmaltais commented May 5, 2023

OK, before I merge, I wonder if you would feel OK to adapt the code to leverage the central common_gui.py implementation vs carrying the config gradio block in each trainer GUI. I know, it is almost as much work given the sprawling of variables in each any way... but if one needed to change the gradio elements in the future this allow to make the change in only one file vs 4.

Let me know if you can tackle this. Otherwise I might refactor the code to implement it using the common_gui.ps in the library folder in the future.

@x-CK-x
Copy link
Contributor Author

x-CK-x commented May 5, 2023

Just went back and adapted it to the common gui implementation.

@bmaltais
Copy link
Owner

bmaltais commented May 5, 2023

Awesome, will make updates more user freindly if ever needed in the future. I will merge to dev and let it soak until the next release.

@bmaltais bmaltais changed the base branch from master to dev May 5, 2023 18:34
@bmaltais bmaltais merged commit 6333b38 into bmaltais:dev May 5, 2023
bmaltais pushed a commit that referenced this pull request Aug 5, 2023
fix training textencoder in sdxl not working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants