fixes #95 FilepathGlob("") should return nil

bmatcuk · Oct 11, 2024 · 1e20c6d · 1e20c6d
1 parent da152ef
commit 1e20c6d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/doublestar_test.go b/doublestar_test.go
@@ -28,6 +28,7 @@ type MatchTest struct {
 var onWindows = runtime.GOOS == "windows"
 
 var matchTests = []MatchTest{
+	{"", "", true, false, nil, true, false, true, true, 0, 0},
 	{"*", "", true, true, nil, false, false, true, false, 0, 0},
 	{"*", "/", false, false, nil, false, false, true, false, 0, 0},
 	{"/*", "/", true, true, nil, false, false, true, false, 0, 0},

diff --git a/utils.go b/utils.go
@@ -84,6 +84,16 @@ func SplitPattern(p string) (base, pattern string) {
 // filepath.ErrBadPattern.
 //
 func FilepathGlob(pattern string, opts ...GlobOption) (matches []string, err error) {
+	if pattern == "" {
+		// special case to match filepath.Glob behavior
+		g := newGlob(opts...)
+		if g.failOnIOErrors {
+			// match doublestar.Glob behavior here
+			return nil, os.ErrInvalid
+		}
+		return nil, nil
+	}
+
 	pattern = filepath.Clean(pattern)
 	pattern = filepath.ToSlash(pattern)
 	base, f := SplitPattern(pattern)